[Pidgin] #14473: Change PurpleStoredImg refcount type

[Pidgin]

#14473: Change PurpleStoredImg refcount type
--------------------------+-------------------------------------------------
 Reporter:  hanzz         |     Owner:  rekkanoryo
     Type:  defect        |    Status:  new       
Component:  unclassified  |   Version:  2.9.0     
 Keywords:                |  
--------------------------+-------------------------------------------------
 Hi,

 In my libpurple usecase, I connect lot of users and set the same avatar
 for each of them. prpl-msn creates 3-5 refs to it (lets presume 4).

 Current type of refcount variable is guint8, so there can be just 255
 refs, otherwise guint8 overflows and libpurple crashes or frees random
 memory later.

 In my case it means I can have just something about 63 users online. I
 would suggest to change guint8 to to guint16, which will be enough for all
 usecase.

 Since PurpleStoredImg is declared in .c, it can be done without breaking
 API.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/14473>
Pidgin <http://pidgin.im>
Pidgin