[Pidgin] #13376: Enhancement for StateNotify so it post buddy notifications into chats as well.

[Pidgin]

#13376: Enhancement for StateNotify so it post buddy notifications into chats as
well.
------------------------------------------+---------------------------------
 Reporter:  ifko                          |        Owner:           
     Type:  enhancement                   |       Status:  pending  
Milestone:  Patches Needing Improvement   |    Component:  libpurple
  Version:  2.7.10                        |   Resolution:           
 Keywords:  statenotify libpurple plugin  |  
------------------------------------------+---------------------------------
Changes (by deryni):

  * status:  new => pending
  * milestone:  => Patches Needing Improvement


Comment:

 Your patch is inverted. diff takes the original file and then the new
 file. But that's ok, patch has an option to handle this since it happens a
 lot.

 That being said the patch looks generally ok though it doesn't quite
 follow pidgin style (i.e. it uses studlyCaps). Also, this isn't going to
 always be correct. Namely, I think it will fail on protocols where chat
 room names are non-unique (that is where you can set a different nickname
 for every chatroom you join and where chatroom nicknames are therefore not
 necessarily connected to your service username). You probably need to add
 a check for that feature and/or the chat buddy being an actual buddy list
 buddy.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13376#comment:1>
Pidgin <http://pidgin.im>
Pidgin