[Pidgin] #13370: libpurple jabber does not process avatar removal updates

[Pidgin]

#13370: libpurple jabber does not process avatar removal updates
-----------------------------------------+----------------------------------
 Reporter:  mentor                       |        Owner:  deryni 
     Type:  defect                       |       Status:  pending
Milestone:  Patches Needing Improvement  |    Component:  XMPP   
  Version:  2.7.10                       |   Resolution:         
 Keywords:                               |  
-----------------------------------------+----------------------------------
Changes (by darkrain42):

  * status:  new => pending
  * milestone:  Patches Needing Review => Patches Needing Improvement


Comment:

 The logic for determining to unset an avatar appears incorrect to me.  It
 should check for an empty <photo/> element (see
 [http://xmpp.org/extensions/xep-0153.html#bizrules-presence XEP-0153 4.1
 #3]):

 {{{
 If there is no avatar image to be advertised, the photo element MUST be
 empty, i.e.:
 ...
 Note: This enables recipients to distinguish between the absence of an
 image (empty photo element) and mere support for the protocol (empty
 update child)
 }}}

 I also vehemently object to this code on readability grounds:
 `if (!!ah != !!ah2...`

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13370#comment:3>
Pidgin <http://pidgin.im>
Pidgin