[Pidgin] #1449: Can't join AIM chatrooms (only sometimes; Pidgin doesn't crash)

[Pidgin]

#1449: Can't join AIM chatrooms (only sometimes; Pidgin doesn't crash)
--------------------------------+-------------------------------------------
 Reporter:  Refinery            |        Owner:  MarkDoliner
     Type:  defect              |       Status:  new        
Milestone:                      |    Component:  AIM        
  Version:  2.0.1               |   Resolution:             
 Keywords:  AIM chat room join  |  
--------------------------------+-------------------------------------------

Comment(by MarkDoliner):

 Looks like the current version of the Windows AIM clients sends some sort
 of keepalive every 178 or 179 seconds.  Pidgin only sends keepalives on
 the primary FLAP connection.  We should probably send keepalives on all
 FLAP connections.

 If anyone compiles Pidgin themselves and wants to test, you could try this
 patch:
 {{{
 ============================================================
 --- libpurple/protocols/oscar/oscar.c
 d2c9d3d86e975571c10f6163835a48696e3e2b81
 +++ libpurple/protocols/oscar/oscar.c
 1832433d5ba5e7cffb9ef3f207f2af3281d3d32e
 @@ -3140,12 +3140,12 @@ oscar_keepalive(PurpleConnection *gc)
  oscar_keepalive(PurpleConnection *gc)
  {
         OscarData *od;
 -       FlapConnection *conn;
 +       GSList *l;

         od = purple_connection_get_protocol_data(gc);
 -       conn = flap_connection_getbytype(od, SNAC_FAMILY_LOCATE);
 -       if (conn != NULL)
 -               flap_connection_send_keepalive(od, conn);
 +       for (l = od->oscar_connections; l; l = l->next) {
 +               flap_connection_send_keepalive(od, l->data);
 +       }
  }

  unsigned int
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1449#comment:51>
Pidgin <http://pidgin.im>
Pidgin