[Pidgin] #13298: Cannot add msn buddy: error msg about invalid email address

[Pidgin]

#13298: Cannot add msn buddy: error msg about invalid email address
---------------------+------------------------------------------------------
 Reporter:  flohack  |        Owner:  QuLogic
     Type:  defect   |       Status:  new    
Milestone:           |    Component:  MSN    
  Version:  2.7.9    |   Resolution:         
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by MarkDoliner):

 Here's what I've learned, please correct me if I'm wrong.
  1. Before actually adding the buddy, libpurple makes an FQY request to
 try to determine the network type ("t") of the buddy.
  1. Once we know the network type ("1" for normal hotmail/MSN/Windows Live
 contacts and "32" for Yahoo! contacts) then we make the two ADL requests
 to add the buddy
  1. For some reason the FQY request is now returning t=0 ("unknown")
 instead of t=1 ("normal msn")
  1. Somehow the official Windows Live Messenger client seems to know that
 MSN buddies are MSN buddies and it doesn't make an FQY request before
 making the ADL request.  Make it learns something while updating the
 server-stored address book?  When adding a Yahoo buddy the official
 Windows Live Messenger client does still issue the FQY request BEFORE the
 ADL, and the FQY does return t=32, as expected.
  1. To fix this ticket I think if our FQY request returns "0" then we can
 treat it as "1" and continue adding rather than bailing out.  This seems
 to fix the problem for me when testing locally.  It doesn't seem to cause
 any harm.  If the username doesn't exist we'll get a "username does not
 exist" error message a little farther down the road (the SOAP add request
 to http://www.msn.com/webservices/AddressBook/ABContactAdd returns HTTP
 500 Internal Server Error with <errorcode>InvalidPassportUser</errorcode>

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13298#comment:38>
Pidgin <http://pidgin.im>
Pidgin