[Pidgin] #12472: Yahoo File Transfer... Still....

[Pidgin]

#12472: Yahoo File Transfer... Still....
---------------------------------+------------------------------------------
 Reporter:  Swashbunglar         |        Owner:  sulabh.dev         
     Type:  defect               |       Status:  new                
Milestone:  Patches welcome      |    Component:  Yahoo!/Yahoo! JAPAN
  Version:  2.7.3                |   Resolution:                     
 Keywords:  Yahoo File Transfer  |  
---------------------------------+------------------------------------------

Comment(by cristi):

 Patch included! :)

 File transfers succeeding but pidgin not recognizing that - happens to me
 as well (pidgin->kopete, and pidgin->windows Yahoo Messenger). Behavior as
 previously reported.

 Problem lies in the fact that completed state is not evaluated correctly
 by the underlying protocol file transfer implementation and neither by the
 general libpurple file transfer module.

 Below, simple patch. Tested with file transfer  pidgin->kopete,
 pidgin->Yahoo messenger (v10?)

 Would probably fix also bugs #13058 and #12670.

 Patch on source code version 2.7.9:

 --- ft.c.orig   2011-01-16 11:01:54.000000000 +0200
 +++ ft.c        2011-01-16 11:05:44.000000000 +0200
 @@ -1100,9 +1100,11 @@
                 r = write(xfer->fd, buffer, s);
                 if (r < 0 && errno == EAGAIN)
                         r = 0;
 -               if ((purple_xfer_get_bytes_sent(xfer)+r) >=
 purple_xfer_get_size(xfer))
 -                       purple_xfer_set_completed(xfer, TRUE);
         }
 +       if (r >= 0 && (purple_xfer_get_bytes_sent(xfer)+r) >=
 purple_xfer_get_size(xfer) &&
 +               !purple_xfer_is_completed(xfer))
 +               purple_xfer_set_completed(xfer, TRUE);
 +

         return r;
  }

-- 
Ticket URL: <http://developer.pidgin.im/ticket/12472#comment:35>
Pidgin <http://pidgin.im>
Pidgin