[Pidgin] #13238: vvconfig: Use compare function that will not crash on NULL string

Pidgin trac at pidgin.im
Fri Jan 21 19:13:21 EST 2011


#13238: vvconfig: Use compare function that will not crash on NULL string
-----------------------------------------+----------------------------------
 Reporter:  haakon                       |        Owner:         
     Type:  patch                        |       Status:  new    
Milestone:  Patches Needing Improvement  |    Component:  plugins
  Version:  2.7.9                        |   Resolution:         
 Keywords:  vvconfig crash strcmp        |  
-----------------------------------------+----------------------------------

Comment(by haakon):

 From the code I can't see any reason for those terminating NULLs, I
 removed them and it seems to work correctly, no more crashes on strcmp
 now. Maybe original developer can give explanation if this was some relict
 code from previous implementation.

 Please review the new patch, I also found that we should use
 g_list_find_custom() in device_changed_cb() function.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13238#comment:5>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list