[Pidgin] #13290: Fix Crash in Voice/Video Config

[Pidgin]

#13290: Fix Crash in Voice/Video Config
-----------------------------+----------------------------------------------
 Reporter:  paerley          |     Owner:  Maiku
     Type:  patch            |    Status:  new  
Component:  Voice and Video  |   Version:  2.7.9
 Keywords:                   |  
-----------------------------+----------------------------------------------
 I've been getting:

 {{{
 Program received signal SIGSEGV, Segmentation fault.
 get_element_devices (element_name=0x747ec0 "xvimagesink") at vvconfig.c:93
 93              klass = G_OBJECT_GET_CLASS (element);
 (gdb) bt
 #0  get_element_devices (element_name=0x747ec0 "xvimagesink") at
 vvconfig.c:93
 #1  0x00007fffea1e2157 in get_plugin_frame (parent=<value optimized out>,
 sg=0x1149a60, name=<value optimized out>,
     plugin_label=0x7fffea1e36f8 "_Plugin", plugin_strs=<value optimized
 out>,
     plugin_pref=0x7fffea1e3440 "/plugins/gtk/vvconfig/video/sink/plugin",
 device_label=0x7fffea1e36f0 "_Device",
     device_pref=0x7fffea1e3468 "/plugins/gtk/vvconfig/video/sink/device")
 at vvconfig.c:261
 #2  0x00007fffea1e24e0 in get_plugin_config_frame (plugin=<value optimized
 out>) at vvconfig.c:311
 #3  0x00007fffea1e2995 in show_config (action=<value optimized out>) at
 vvconfig.c:514
 #4  0x00007ffff0989efe in g_closure_invoke () from
 /usr/lib/libgobject-2.0.so.0
 #5  0x00007ffff099b3e7 in signal_emit_unlocked_R () from
 /usr/lib/libgobject-2.0.so.0
 #6  0x00007ffff09a4c95 in g_signal_emit_valist () from
 /usr/lib/libgobject-2.0.so.0
 #7  0x00007ffff09a4e63 in g_signal_emit () from
 /usr/lib/libgobject-2.0.so.0
 #8  0x00007ffff638e27e in gtk_widget_activate () from
 /usr/lib/libgtk-x11-2.0.so.0
 #9  0x00007ffff628721d in gtk_menu_shell_activate_item () from
 /usr/lib/libgtk-x11-2.0.so.0
 #10 0x00007ffff62875b7 in gtk_menu_shell_button_release () from
 /usr/lib/libgtk-x11-2.0.so.0
 #11 0x00007ffff6273b98 in _gtk_marshal_BOOLEAN__BOXED () from
 /usr/lib/libgtk-x11-2.0.so.0
 #12 0x00007ffff0989efe in g_closure_invoke () from
 /usr/lib/libgobject-2.0.so.0
 #13 0x00007ffff099b1f8 in signal_emit_unlocked_R () from
 /usr/lib/libgobject-2.0.so.0
 #14 0x00007ffff09a4a35 in g_signal_emit_valist () from
 /usr/lib/libgobject-2.0.so.0
 #15 0x00007ffff09a4e63 in g_signal_emit () from
 /usr/lib/libgobject-2.0.so.0
 #16 0x00007ffff638f08f in gtk_widget_event_internal () from
 /usr/lib/libgtk-x11-2.0.so.0
 #17 0x00007ffff6271d53 in gtk_propagate_event () from
 /usr/lib/libgtk-x11-2.0.so.0
 #18 0x00007ffff6272103 in gtk_main_do_event () from
 /usr/lib/libgtk-x11-2.0.so.0
 #19 0x00007ffff5ee12ec in gdk_event_dispatch () from
 /usr/lib/libgdk-x11-2.0.so.0
 #20 0x00007fffef9304d3 in g_main_context_dispatch () from
 /usr/lib/libglib-2.0.so.0
 #21 0x00007fffef930cb0 in g_main_context_iterate.clone.5 () from
 /usr/lib/libglib-2.0.so.0
 #22 0x00007fffef931322 in g_main_loop_run () from
 /usr/lib/libglib-2.0.so.0
 #23 0x00007ffff6271107 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
 #24 0x00000000004868bd in main (argc=1, argv=0x7fffffffdc98) at
 gtkmain.c:978
 }}}

 Whenever I select Tools->Voice/Video Settings->Voice and Video Settings.
 (Full BT attached for posterity)

 The following patch causes it not to crash.  This fixes ticket #12759

 Signed-Off-By: Pat Erley <pat at erley.org>

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13290>
Pidgin <http://pidgin.im>
Pidgin