[Pidgin] #14245: [PATCH] Make the username_entry hint fully visible

Pidgin trac at pidgin.im
Fri Jun 3 10:15:26 EDT 2011


#14245: [PATCH] Make the username_entry hint fully visible
--------------------+-------------------------------------------------------
Reporter:  sbrabec  |        Type:  defect      
  Status:  new      |   Component:  pidgin (gtk)
 Version:  2.7.11   |    Keywords:              
--------------------+-------------------------------------------------------
 The Add account GUI does not take in account the size of the username hint
 (login_label), which may render this label unreadable.

 Technical details: pidgin abuses GtkEntry to display informative text
 which disappears on click. GtkEntry is not aware of such abuse and ignores
 size of text, as it implements its own scrolling mechanism. It makes the
 text concatenated.

 GtkEntry does not provide direct access to the entry text widget (and
 probably even does not have such), just a entry text GdkWindow. This
 GdkWindow is not yet initialized in time of the widget creation, so I have
 to repeat computations from gtk+/gtk/gtkentry.c
 _gtk_entry_effective_inner_border().

 That is why the patch is a bit ugly, as well as adding an auto-
 disappearing string into GtkEntry. Another solution would less hacky way
 to display hint.

 The patch also modifies the hint color from a hardcoded color to a theme-
 wise color.

 The patch is still a bit incomplete. To be perfect, this code should be
 moved to the "notify" handler of the default style, so it will reformat
 GUI after theme change.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/14245>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list