[Pidgin] #1034: Own User Info background color reverts to white on edit

Pidgin trac at pidgin.im
Tue Jun 14 19:28:19 EDT 2011


#1034: Own User Info background color reverts to white on edit
-----------------------+----------------------------------------------------
 Reporter:  Johnny K   |        Owner:  seanegan    
     Type:  defect     |       Status:  new         
Milestone:             |    Component:  pidgin (gtk)
  Version:  2.0        |   Resolution:              
 Keywords:  user info  |  
-----------------------+----------------------------------------------------

Comment(by lukas_p):

 Anybody mentioned, that this '''can be reproduced in most text boxes'''
 like normal chats too?

 Steps to reproduce:
 "New instant message..." -> enter a alias (for example your own ICQ-
 Number) -> enter some text -> do not select it -> change background color
 -> send it

 Result:
 sent message has previous background color instead of the recently
 selected background color.

 Expected:
 sent massage has recently chosen background color

 For me, this is somehow an inconsistent/strange behavior:
 For every other formatting that users modify (bold, underline, font-size,
 ...) the changes are only applied to '''newly entered or selected''' text.

 If you change the background color (without having anything selected) the
 background is applied to the '''whole text''' an suggests it is actually
 changed (but it is not). If then, users enter some more text, this new
 text will have that background.

 I solved it by ''not'' changing the "body color" but to add "font
 background color" to newly entered text and thus behave like every other
 change to the formatting. See patch.
 Yes, this is a heavy change of the imhtml backend (read: "setting the body
 color gets nearly impossible"). It will affect all other imhtml-enabled
 text boxes.

 I also thought of making an exception only for the "body background color"
 or - if there should not be an exception -  we could check ''all''
 formatting options to be set right before saving. The latter would be a
 "new" consistent behavior.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/1034#comment:14>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list