[Pidgin] #14297: purple_parse_oncoming() passes NULL pointer to printf()

[Pidgin]

#14297: purple_parse_oncoming() passes NULL pointer to printf()
--------------------------+-------------------------------------------------
 Reporter:  clh           |     Owner:  rekkanoryo
     Type:  defect        |    Status:  new       
Component:  unclassified  |   Version:  2.7.11    
 Keywords:                |  
--------------------------+-------------------------------------------------
 In libpurple/protocols/oscar/oscar.c there are two places where a NULL
 pointer can be passed to purple_debug_info() and ultimately a printf
 variant:


 {{{
   1456          message = (info->status && info->status_len > 0)
   1457                          ?
 oscar_encoding_to_utf8(info->status_encoding, info->status,
 info->status_len)
   1458                          : NULL;
 }}}


 {{{
   1464                          itmsurl = (info->itmsurl_len > 0) ?
 oscar_encoding_to_utf8(info->itmsurl_encoding, info->itmsurl,
 info->itmsurl_len) : NULL;

 }}}

 Both itmsurl and message are passed as character pointers to
 purple_debug_info() and ultimately to a printf variant:


 {{{
   1468                  purple_debug_info("oscar", "Activating status '%s'
 for buddy %s, message = '%s', itmsurl = '%s'\n", status_id, info->bn,
 message, itmsurl);

   1471                  purple_debug_info("oscar", "Activating status '%s'
 for buddy %s, message = '%s'\n", status_id, info->bn, message);

 }}}

 This diff fixes these places:

 {{{
 --- oscar.c.old Tue Jun  7 10:44:41 2011
 +++ oscar.c     Wed Jun 15 15:56:22 2011
 @@ -1455,13 +1455,13 @@

         message = (info->status && info->status_len > 0)
                         ? oscar_encoding_to_utf8(info->status_encoding,
 info->status, info->status_len)
 -                       : NULL;
 +                       : "";

         if (strcmp(status_id, OSCAR_STATUS_ID_AVAILABLE) == 0) {
                 /* TODO: If itmsurl is NULL, does that mean the URL has
 been
                    cleared?  Or does it mean the URL should remain
 unchanged? */
                 if (info->itmsurl != NULL) {
 -                       itmsurl = (info->itmsurl_len > 0) ?
 oscar_encoding_to_utf8(info->itmsurl_encoding, info->itmsurl,
 info->itmsurl_len) : NULL;
 +                       itmsurl = (info->itmsurl_len > 0) ?
 oscar_encoding_to_utf8(info->itmsurl_encoding, info->itmsurl,
 info->itmsurl_len) : "";
                 } else if (previous_status != NULL &&
 purple_status_is_available(previous_status)) {
                         itmsurl =
 g_strdup(purple_status_get_attr_string(previous_status, "itmsurl"));
                 }

 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/14297>
Pidgin <http://pidgin.im>
Pidgin