[Pidgin] #13465: Patch for using mood messages with ICQ
Pidgin
trac at pidgin.im
Mon Mar 7 21:14:09 EST 2011
#13465: Patch for using mood messages with ICQ
------------------------------------------------------------+---------------
Reporter: dustin | Owner: MarkDoliner
Type: patch | Status: new
Component: ICQ | Version: 2.7.10
Keywords: x-status mood comment message check visibility |
------------------------------------------------------------+---------------
This patch changes libpurple's behaviour to actually send the mood message
upon an x-status request.
The text entry field in the User Mood dialog is activated now.
Changes to protocols/oscar/icbm.c:
- The x-status reply now contains:
title: "" (No use for this field at the moment. We only have one text
field and other information at hand, like the mood's name, is already
displayed anyway)
description: the x-status mood message (= mood comment).
(Formerly, the reply contained only the redundant availability status
information)
- Fixed a typo in the XML template string for x-status replies. Because of
this other clients could not read Pidgin's x-status messages.
- No reply is sent if the request comes from a buddy to whom we are
invisible at the moment (else the reply could be used to probe if we are
online).
Also includes two new public functions:
- oscar_is_visible_to_buddy() in protocols/oscar/visibility.c:
Checks if a particular buddy can see us right now. If we want to be
really, really invisible to a buddy, we should not send any replies. Maybe
this function could also be useful in other places of the code.
- purple_str_truncate_at_pos() in util.c.
Truncates a string and puts a "..." at the end.
I've seen these few lines in several places in the code and separated
them just for reasons of readability. Hope this is alright.
--
Ticket URL: <http://developer.pidgin.im/ticket/13465>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list