[Pidgin] #4816: Oscar protocol performance improvement(s)

Pidgin trac at pidgin.im
Thu Mar 17 04:11:08 EDT 2011


#4816: Oscar protocol performance improvement(s)
-------------------------------------+--------------------------------------
 Reporter:  oliver                   |        Owner:  MarkDoliner
     Type:  patch                    |       Status:  new        
Milestone:  Patches Needing Review   |    Component:  AIM        
  Version:  2.3.1                    |   Resolution:             
 Keywords:  oscar performance patch  |  
-------------------------------------+--------------------------------------

Comment(by MarkDoliner):

 Alright, here's what I've come up with.  Still have a linked list sorted
 by gid+bid.  Added the hash table indexed by gid+bid (basically same as in
 your patch).  Added a hash table indexed by type+name (different than your
 patch, used to look up anything with a name where you don't care about
 what group it's in).

 Looking up the item for a specific buddy in a specific group still
 iterates through the whole list.  I think this happens once per buddy at
 signon, but I feel like it might be possible to stop doing that.  In any
 case, the attached patch seems to work ok for me and I think it's an
 improvement.  I'll probably check it into the im.pidgin.pidgin.next.major
 branch sometime in the next few days.  If anyone wants to test it before
 then, please let me know if you have any problems.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/4816#comment:19>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list