[Pidgin] #13533: Birthday in ICQ profile may be one day off because of daylight savings time

[Pidgin]

#13533: Birthday in ICQ profile may be one day off because of daylight savings time
---------------------------------------------------+------------------------
 Reporter:  dustin                                 |     Owner:  MarkDoliner
     Type:  defect                                 |    Status:  new        
Component:  ICQ                                    |   Version:  2.7.11     
 Keywords:  birthday profile dst daylight savings  |  
---------------------------------------------------+------------------------
 ''(minor bug)''

 The birthday date shown in the ICQ profile (Buddy information) may be one
 day earlier or later than what it actually is.

 Currently, between 23h and 0h the date is incremented by one day.
 This is the case for dates in summer time (daylight savings time).
 For example, May 01 will be shown as May 02.


 Also tested the reverse case:
 In summer time (between 0h and 1h) the date is decremented by one day for
 dates that lie in winter time.
 For example, March 01 is shown as Feb 28 then.


 I think the problem is that the tm struct still contains the hour and dst
 information of the current time.
 In case today and birthday are not in the same dst period, {{{mktime()}}}
 will convert dst and time to the "correct" setting and introduce a
 timeshift.

 It should be sufficient to switch {{{tm_isdst}}} to {{{-1}}}, i.e. "dst
 information is not known" (worked for me).

 Otherwise, the time could be changed to 12:00:00 to avoid trouble.


 System used:
  * Ubuntu Linux 09.10
  * time zone: CET +0100 (central european time) / CEST +0200

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13533>
Pidgin <http://pidgin.im>
Pidgin