[Pidgin] #13554: multiple empty messages when receiving image

[Pidgin]

#13554: multiple empty messages when receiving image
------------------------+---------------------------------------------------
 Reporter:  tomkiewicz  |        Owner:  bartosz  
     Type:  patch       |       Status:  new      
Milestone:              |    Component:  Gadu-Gadu
  Version:  2.7.11      |   Resolution:           
 Keywords:  images      |  
------------------------+---------------------------------------------------

Old description:

> When somebody sends me an image, I get some (depends on image size) empty
> messages. It's about one empty message for every 2kB of image.
>
> Steps to reproduce:
>  1. install and run AQQ on Windows (because pidgin doesn't support
> sending images via gg), login with one gg account
>  2. run Pidgin 2.7.11 under linux, login with another gg account
>  3. send ~50kB image from AQQ to Pidgin
>  4. you should get 20-30 received empty messages in Pidgin and one with
> image after it
>
> I fixed it by checking if gg message is empty and - if true - drops the
> message and print warning in debug window.

New description:

 When somebody sends me an image, I get some (depends on image size) empty
 messages. It's about one empty message for every 2kB of image.

 Steps to reproduce:
  1. install and run AQQ on Windows (or any other gadu-gadu client with
 image sending support), login with one gg account
  2. run Pidgin 2.7.11 under linux (maybe on Windows too), login with
 another gg account
  3. send ~50kB image from AQQ to Pidgin
  4. you should get 20-30 received empty messages in Pidgin and one with
 image after it

 I fixed it by checking if gg message is empty and - if true - drops the
 message and print warning in debug window.

--

Comment(by tomkiewicz):

 Libgadu 1.10.1 puts NULL instead of empty string in broken messages - so
 after update to 1.10.1 (#13525) the second patch will be suitable.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13554#comment:1>
Pidgin <http://pidgin.im>
Pidgin