[Pidgin] #13580: Broken sending images support (via Gadu-gadu)

[Pidgin]

#13580: Broken sending images support (via Gadu-gadu)
------------------------+---------------------------------------------------
 Reporter:  tomkiewicz  |     Owner:  bartosz
     Type:  patch       |    Status:  new    
Component:  Gadu-Gadu   |   Version:  2.7.11 
 Keywords:  images      |  
------------------------+---------------------------------------------------
 Sending images (via Gadu-gadu protocol) feature was broken some time ago.
 At first it doesn't work. At second it crashes Pidgin if we try to send
 large images.

 Steps to reproduce:
  1. start conversation with another gadu-gadu user
  2. attach an image via Chat -> Insert image (i don't know exact
 translation of "Rozmowa -> Wstaw obraz" in Polish)
  3. press enter - image should appear on conversation log (suggesting that
 recipient got it)
  4. recipient gets nothing (even not a single empty message)

 Another problem:
  1. start conversation like before
  2. attach image larger than 256kB
  3. press enter - Pidgin hangs and gets 50% of (dual core) CPU usage

 I found out, where was a bug. It was improper use of pointers. Someone
 stored (in global hash map) pointer to variable, which was on stack. I
 replaced pointers with values (i think it was original intention).

 Also problem with big images was also solved. There was an infinite loop,
 probably copy-paste from other part of Pidgin source.

 Both fixed and works well for me. Sending images works again, after such a
 long time :).

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13580>
Pidgin <http://pidgin.im>
Pidgin