[Pidgin] #13959: httpconn.c: strange code (noop)

Pidgin trac at pidgin.im
Wed May 4 22:59:39 EDT 2011


#13959: httpconn.c: strange code (noop)
------------------------+---------------------------------------------------
 Reporter:  darkrain42  |     Owner:  QuLogic
     Type:  defect      |    Status:  new    
Component:  MSN         |   Version:  2.7.11 
 Keywords:              |  
------------------------+---------------------------------------------------
 {{{
 httpconn.c:115:14: warning: Both operands to '-' always have the same
 value
                 size -= (s - buf);
                          ~ ^ ~~~
 httpconn.c:115:8: warning: The right operand to '-=' is always 0
                 size -= (s - buf);

                 buf = s;
                 size -= (s - buf);
 }}}

 {{{
 (19:51:52) darkrain: It was last touched 5 years ago by Mark ;)
 (19:52:46) Masca: do you have the commit log?
 (19:52:59) darkrain: It's quite large, revision
 5961f634688b3733d93b4b8bd7af99f04b1afe61
 (19:59:49) Masca: Mmmm... maybe that buf = s; must not be there.
 (20:00:21) darkrain: Or the other needs to go first, or...something.  I'm
 unwilling to touch such core parsing code :/
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13959>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list