[Pidgin] #13947: Ability to create 1000+ accounts

Pidgin trac at pidgin.im
Tue May 10 00:20:40 EDT 2011

#13947: Ability to create 1000+ accounts
 Reporter:  gugu                         |        Owner:           
     Type:  patch                        |       Status:  new      
Milestone:  Patches Needing Improvement  |    Component:  libpurple
  Version:                               |   Resolution:           
 Keywords:  accounts spectrum            |  
Changes (by darkrain42):

  * milestone:  Patches Needing Review => Patches Needing Improvement


 Some more feedback:
    * Use g_list_delete_link, not g_list_remove_link (the former frees the
 GList, the latter does not)
    * Please use consistent indentation.  See [wiki:CodingStandards], but
 always tabs for indentation (second-level is two tabs, not 8 spaces)
    * lookup_key is leaked in purple_accounts_find
    * The data in the array is never freed.  Take a look at
 g_hash_table_remove and g_hash_table_new_full (value_destroy_func is going
 to be NULL)
    * I think you need normalization of the value stored in the array.
 [[BR]] Consider the case where I start with my XMPP account as "PAUL -AT-
 DARKRAIN42.ORG/pidgin" (s/-AT-/@/), and then rename it to "paul -at-
 darkrain42.org/pidgin".  From an XMPP perspective, exactly the same.  From
 a g_str_equal perspective, completely different.  [[BR]] Look at how
 purple_accounts_find currently uses purple_normalize, and use
 purple_normalize when building a key for storage/lookup.

 This last point means you also need to account for renames

Ticket URL: <http://developer.pidgin.im/ticket/13947#comment:4>
Pidgin <http://pidgin.im>

More information about the Tracker mailing list