[Pidgin] #13270: SASL support on IRC Protocol
Pidgin
trac at pidgin.im
Wed Aug 8 14:56:14 EDT 2012
#13270: SASL support on IRC Protocol
------------------------------------+---------------------------------------
Reporter: Gaming4JC | Owner: elb
Type: patch | Status: new
Milestone: Patches Needing Review | Component: IRC
Version: 2.7.9 | Resolution:
Keywords: |
------------------------------------+---------------------------------------
Comment(by elb):
The patch is not "written well", and it's been discussed in the XMPP chat.
It is still a hack. I'll put the details here for the benefit of those
who missed it.
* This patch hand-implements SASL PLAIN, which is a bad idea for both
security and flexibility reasons. Other protocols use Cyrus SASL, as this
should.
* The strncmp() check is wrong (it should use len 5).
* There is no indication to the client that the authentication succeeded
or failed.
--
Ticket URL: <http://developer.pidgin.im/ticket/13270#comment:15>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list