[Pidgin] #12637: Pdgin crash when accepting a sametime chatroom invitation

Pidgin trac at pidgin.im
Wed Aug 15 13:03:25 EDT 2012

#12637: Pdgin crash when accepting a sametime chatroom invitation
 Reporter:  angejudor                        |        Owner:  siege   
     Type:  defect                           |       Status:  new     
Milestone:                                   |    Component:  Sametime
  Version:  2.8.0                            |   Resolution:          
 Keywords:  sametime chatroom crash windows  |  

Comment(by jhkrischel):

 Replying to [comment:16 jricesterenator]:
 > I'm not a C pro either, but I'm not sure that conditional would work.
 > As background, mString_get(...) grabs the next string element from the
 buffer, advances a position counter, and stores the result in
 m->extraname. So m->extraname won't really exist until you call
 mString_get(b, &m->extraname).

 Okay, so when the mwString_get(b, &m->extraname); call is made, there seem
 to be two options -> either b (the buffer with the data) will be valid and
 we'll set &m->extraname, or b will be null, and the mwString_get(...)
 function will hit this line:

 g_return_if_fail(b != NULL);

 The way I read that is that if b == NULL, it will return.  mw_str_get()
 returns void, so my guess is that it gracefully fails.

Ticket URL: <http://developer.pidgin.im/ticket/12637#comment:19>
Pidgin <http://pidgin.im>

More information about the Tracker mailing list