[Pidgin] #15292: [gtk3] Blist resize when minidialog shows up

Pidgin trac at pidgin.im
Mon Aug 27 18:46:43 EDT 2012


#15292: [gtk3] Blist resize when minidialog shows up
-----------------------------------+----------------------------------------
 Reporter:  salinasv               |        Owner:  QuLogic     
     Type:  patch                  |       Status:  new         
Milestone:                         |    Component:  pidgin (gtk)
  Version:  2.10.6                 |   Resolution:              
 Keywords:  gtk3 minidialog blist  |  
-----------------------------------+----------------------------------------
Description changed by salinasv:

Old description:

> Minidialog blist_width_changed_cb() is changing the widget size 4 points
> bigger than the blist. This makes the blist change and thus re-trigger
> this same callback starting a non-stop loop.
>
> I found that changing this solve the problem.
> {{{
> -((PIDGIN_HIG_BOX_SPACE*3) + 16)
> +((PIDGIN_HIG_BOX_SPACE*3) + 20)
> }}
>
> The problem is that I don't know what changed by 4 pixels in Gtk3. And I
> don't like that magic numbers. =P

New description:

 Minidialog blist_width_changed_cb() is changing the widget size 4 points
 bigger than the blist. This makes the blist change and thus re-trigger
 this same callback starting a non-stop loop.

 I found that changing this in minidialog.c:461 solve the problem.
 {{{
 -((PIDGIN_HIG_BOX_SPACE*3) + 16)
 +((PIDGIN_HIG_BOX_SPACE*3) + 20)
 }}

 The problem is that I don't know what changed by 4 pixels in Gtk3. And I
 don't like that magic numbers. =P

--

-- 
Ticket URL: <http://developer.pidgin.im/ticket/15292#comment:1>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list