[Pidgin] #14958: Drop unnecessary MAKENSISOPT
Pidgin
trac at pidgin.im
Fri Feb 24 23:01:22 EST 2012
#14958: Drop unnecessary MAKENSISOPT
------------------------+---------------------------------------------------
Reporter: renatosilva | Type: patch
Status: new | Component: libpurple
Version: 2.10.1 | Keywords: windows build nsis
------------------------+---------------------------------------------------
This patch eliminates MAKENSISOPT from Windows Pidgin build since
makensis.exe does support dashed arguments:
{{{
$ makensis.exe -V3 -Dfoo=bar does_work.nsi
}}}
In practice this will fix for example MinGW users complaining about
failing to build Pidgin under MSYS due to having slashes expanded to MSYS'
root:
{{{
$ show_arg /c => c:/
$ show_arg -arg => -arg
$ show_arg /arg => C:/Outros/MinGW/msys/1.0/arg
}}}
Here's a screenshot of the dashed arguments working:
[[Image(http://i.imgur.com/9hlHP.png)]]
--
Ticket URL: <http://developer.pidgin.im/ticket/14958>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list