[Pidgin] #14959: Drop unnecessary MAKENSISOPT from Windows build

[Pidgin]

#14959: Drop unnecessary MAKENSISOPT from Windows build
------------------------+---------------------------------------------------
Reporter:  renatosilva  |        Type:  patch             
  Status:  new          |   Component:  libpurple         
 Version:  2.10.1       |    Keywords:  windows build nsis
------------------------+---------------------------------------------------
 This patch eliminates MAKENSISOPT from Windows build of Pidgin 2.10.1
 given that makensis.exe does support dashed arguments:

 {{{
 $ makensis.exe -V3 -Dfoo=bar does_work.nsi
 }}}

 In practice this will fix for example MinGW users complaining about
 failing to build Pidgin under MSYS due to having slashes expanded to MSYS'
 root:

 {{{
 $ show_arg /c => c:/
 $ show_arg -arg => -arg
 $ show_arg /arg => C:/Outros/MinGW/msys/1.0/arg
 }}}

 A screenshot of the dashed arguments working:

 [[Image(http://i.imgur.com/9hlHP.png)]]

 Drop MAKENSISOPT from Pidgin build 2.10.1

-- 
Ticket URL: <http://developer.pidgin.im/ticket/14959>
Pidgin <http://pidgin.im>
Pidgin