[Pidgin] #13050: Avatars not showing on Yahoo

[Pidgin]

#13050: Avatars not showing on Yahoo
---------------------+------------------------------------------------------
 Reporter:  FireDK   |        Owner:  sulabh.dev         
     Type:  defect   |       Status:  closed             
Milestone:  v2.10.1  |    Component:  Yahoo!/Yahoo! JAPAN
  Version:  2.9.0    |   Resolution:  fixed              
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by thijsalkemade at gmail.com):

 (In [78f01024866db9d9208f8cc09b8321c7ed04c140]):[[BR]]
 *** Plucked rev be5e66abad2af29604bc794cc4c6600ab12751f3
 (rekkanoryo at pidgin.im):
 Remove a bogus short-circuit check intended to prevent downloading the
 same icon
 every time a buddy logs in.  There are three problems with the check:
   * The fact that we already have an icon for the buddy doesn't mean it
 hasn't
     changed on the server since we last downloaded.
   * We should really be checking against the server-provided checksum, but
 we
     don't know how to checksum the same way the server does.
   * We no longer receive a checksum at the YMSG protocol level, so we'd
 have to
     parse such a checksum out of the picture URL, which is going to be
 fragile
     and seems just plain stupid to me.

 It seems better to me all around to just axe the check and potentially
 waste
 some bandwidth.  If someone wants to figure out a bandwidth-saving fix for
 this,
 feel free.

 At any rate, this fixes #13050.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13050#comment:18>
Pidgin <http://pidgin.im>
Pidgin