#14818: [PATCH] Finch should handle conversation-extended signals
-----------------------------------------+----------------------------------
Reporter: hyc | Owner: sadrul
Type: patch | Status: new
Milestone: Patches Needing Improvement | Component: finch (gnt/ncurses)
Version: 2.10.0 | Resolution:
Keywords: signals conversation |
-----------------------------------------+----------------------------------
Comment(by sadrul):
This looks much better. Just one issue from what I can see:
It looks like purple_menu_action_free does not free its |children|. So
purple_menu_action_free needs to have 'g_list_free(act->children);'. In
addition, it either also needs 'g_list_foreach(act->children,
purple_menu_action_free, NULL);', or lines 659-660 in the patch needs to
also be added after line 642.
--
Ticket URL: <http://developer.pidgin.im/ticket/14818#comment:12>
Pidgin <http://pidgin.im>
Pidgin