[Pidgin] #14890: Definition of purple_proxy_connect_socks5 is wrong.

Pidgin trac at pidgin.im
Mon Jan 23 10:40:55 EST 2012


#14890: Definition of purple_proxy_connect_socks5 is wrong.
--------------------------+-------------------------------------------------
 Reporter:  xnyhps        |     Owner:  rekkanoryo
     Type:  defect        |    Status:  new       
Component:  unclassified  |   Version:  2.10.1    
 Keywords:                |  
--------------------------+-------------------------------------------------
 {{{purple_proxy_connect_socks5()}}} was replaced by the account-aware
 {{{purple_proxy_connect_socks5_account()}}}, however, the implementation
 of {{{purple_proxy_connect_socks5()}}} that is there for backwards
 compatibility is wrong.

 It uses:
 {{{
 return purple_proxy_connect_socks5_account(NULL, handle, ...
 }}}

 However, handle should be the first parameter, and account the second, as
 the definition of  {{{purple_proxy_connect_socks5()}}} is:

 {{{
 PurpleProxyConnectData *
 purple_proxy_connect_socks5_account(void *handle, PurpleAccount *account,
 ...
 }}}

-- 
Ticket URL: <http://developer.pidgin.im/ticket/14890>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list