[Pidgin] #14983: Crash in error on ICQ

[Pidgin]

#14983: Crash in error on ICQ
-----------------------------------------+----------------------------------
 Reporter:  xnyhps                       |     Owner:  MarkDoliner
     Type:  defect                       |    Status:  new        
Component:  ICQ                          |   Version:  2.10.1     
 Keywords:  icq crash error snachandler  |  
-----------------------------------------+----------------------------------
 #a15881 has multiple people reporting a crash in:

 {{{
 Exception Type:  EXC_BAD_ACCESS (SIGBUS)
 Exception Codes: KERN_PROTECTION_FAILURE at 0x0000000000000000
 Crashed Thread:  0

 Thread 0 Crashed:
 0   libpurple                           0x007879f0 error + 212
 1   libpurple                           0x00789c80 snachandler + 76
 2   libpurple                           0x0079bc68 parse_snac + 336
 3   libpurple                           0x0079bf90 parse_flap + 188
 4   libpurple                           0x0079c3a4 flap_connection_recv +
 980
 5   libpurple                           0x0079c428 flap_connection_recv_cb
 + 44
 }}}

 The last line in the debug log being:

 {{{
 (Libpurple: oscar) Requesting ICQ alias for xxx
 }}}

 I believe this is a problem in `family_icq.c:error()`: it looks up the
 `original_info_ptr` in a linked list, and then tries to get the `->data`
 from it (line 94), '''before''' checking wether it is `NULL` (line 96),
 i.e., wether the lookup succeeded.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/14983>
Pidgin <http://pidgin.im>
Pidgin