[Pidgin] #14976: MSN (windows live messenger) login hangs with message "file msg.c: line 179 (msn_message_parse_payload): should not be reached"

[Pidgin]

#14976: MSN (windows live messenger) login hangs with message "file msg.c: line 179
(msn_message_parse_payload): should not be reached"
--------------------+-------------------------------------------------------
 Reporter:  sunyj   |        Owner:  QuLogic
     Type:  defect  |       Status:  new    
Milestone:          |    Component:  MSN    
  Version:  2.10.1  |   Resolution:         
 Keywords:          |  
--------------------+-------------------------------------------------------

Comment(by sunyj):

 I found the problem.  The MSG message contains '\0' so strstr stops there
 and fails to find body_dem (please refer to msn_message_parse_payload
 function in msg.c).  I changed strstr to memmem and everything works
 again.

 I think we should consider replace all strstr with memmem at least in msn
 protocol, Windows stuffs are messy.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/14976#comment:3>
Pidgin <http://pidgin.im>
Pidgin