[Pidgin] #15300: Pidgin sends multiple "session-accept" stanzas as response to a Jingle "session-inititate"

[Pidgin]

#15300: Pidgin sends multiple "session-accept" stanzas as response to a Jingle
"session-inititate"
----------------------------------------------------------------+-----------
 Reporter:  dustin                                              |     Owner:  Maiku 
     Type:  patch                                               |    Status:  new   
Component:  Voice and Video                                     |   Version:  2.10.6
 Keywords:  Jingle session-initiate session-accept negotiation  |  
----------------------------------------------------------------+-----------
 As mmlosh pointed out in ticket #15245, Pidgin sends several (namely four)
 `"session-accept"` stanzas during a Jingle session negotiation.
 Also, the additional `session-accept`s contain empty `<transport/>` tags
 which may confuse other clients.

 According to [http://xmpp.org/extensions/xep-0166.html#concepts-session
 XEP-0166], there should be only one `session-accept`, indicating the
 PENDING -> ACTIVE change of the session's state.


 The reason for this behaviour is that `[media.c]
 purple_media_stream_info()` fires 4 `STREAM_INFO` signals for a
 `PURPLE_MEDIA_INFO_ACCEPT` type.

 AFAICS only the first signal (containing both `session->id` and
 `participant`) is useful in `jingle_rtp_stream_info_cb()`.
 The attached patch drops the other 3 signals.

 The attached log file contains some extra debugging lines, important lines
 are marked.


 Regards

-- 
Ticket URL: <http://developer.pidgin.im/ticket/15300>
Pidgin <http://pidgin.im>
Pidgin