[Pidgin] #15837: xfer: regression in API 3.x.x compared to 2.10.x

Pidgin trac at pidgin.im
Mon Dec 16 15:33:26 EST 2013


#15837: xfer: regression in API 3.x.x compared to 2.10.x
---------------------+-----------------------
 Reporter:  stefanb  |      Owner:
     Type:  defect   |     Status:  new
Milestone:  3.0.0    |  Component:  libpurple
  Version:           |   Keywords:  API 3.x.x
---------------------+-----------------------
 The API for the xfer read callback has not changed since API 2.10.x

 {{{
 void purple_xfer_set_read_fnc(PurpleXfer *xfer,
                               gssize (*fnc)(guchar **,
                                             PurpleXfer *)
                              );
 }}}

 What **has** changed is that `xfer->current_buffer_size` is no longer
 available. This value is required by the read callback to determine how
 many bytes can fit into the provided buffer.

 Proposed fixes:

 * add a new `purple_xfer_get_current_buffer_size(xfer)` API function
 * change the function prototype for `fnc` to include the buffer size.


 Noticed when I tried to update third-party SIPE plugin to the latest API
 3.x.x version (changeset: 35114:b833eaa6c76f)

-- 
Ticket URL: <https://developer.pidgin.im/ticket/15837>
Pidgin <https://pidgin.im>
Pidgin


More information about the Tracker mailing list