[Pidgin] #1251: chatroom owning on AOL

Pidgin trac at pidgin.im
Sun Jan 27 04:04:37 EST 2013


#1251: chatroom owning on AOL
------------------------------------+--------------------------
 Reporter:  echoline                |       Owner:  markdoliner
     Type:  patch                   |      Status:  new
Milestone:  Patches Needing Review  |   Component:  AIM
  Version:  2.0                     |  Resolution:
 Keywords:  oscar aol own chatroom  |
------------------------------------+--------------------------

Comment (by QuLogic):

 Some (code-only, not AIM/AOL-specific) review:
 * I don't understand the first checks in `aim_chat_ban` and
 `aim_chat_unban`. Would `od` or `conn` ever be NULL? Do other similar
 functions check them also (I didn't look.) Also, you check whether `sn` is
 NULL after you've already used it in the call to `strlen`.
 * You need to use `g_free` on `screenname`, not `free`.

-- 
Ticket URL: <https://developer.pidgin.im/ticket/1251#comment:9>
Pidgin <http://pidgin.im>
Pidgin


More information about the Tracker mailing list