[Pidgin] #15645: Report failed messages deliveries in conversation window

[Pidgin]

#15645: Report failed messages deliveries in conversation window
-----------------------------------------+---------------------------
 Reporter:  hobarrera                    |       Owner:  rekkanoryo
     Type:  patch                        |      Status:  new
Milestone:  Patches Needing Improvement  |   Component:  unclassified
  Version:  2.10.7                       |  Resolution:
 Keywords:                               |
-----------------------------------------+---------------------------

Comment (by datallah):

 The patch adds API to log.h that assumes logs are file based - after
 looking at the patch more, I realized that you don't need to add the API
 at all, your proposed change could just be done as part of the logging
 implementation. You are right that it changes an assumption that has
 implicitly been made about purple_log_get_logs() being readonly - I'm not
 sure how I feel about that, but it probably doesn't really matter since I
 don't think it's the right way to fix this (see below).

 I still don't think this is the right approach.  It seems pretty hacky to
 just write stuff to logs and even if that wasn't the case, you're not
 guaranteed to get the right log.  It also doesn't provide any notification
 to the user that something went wrong (which I think is more important
 than the logging part).

 I think that it probably would be best just to create a new conversation
 window and write the message to it if there isn't an existing one - this
 way you get the logging and the UI notification (and no popup unless
 you've configured new conversations to steal focus).

-- 
Ticket URL: <https://developer.pidgin.im/ticket/15645#comment:9>
Pidgin <http://pidgin.im>
Pidgin