[Pidgin] #15770: libpurple/OSCAR mishandles multiple IM_TEXT tags

[Pidgin]

#15770: libpurple/OSCAR mishandles multiple IM_TEXT tags
-------------------------+-------------------------------------------------
 Reporter:  Auggie       |      Owner:
     Type:  defect       |     Status:  new
Milestone:               |  Component:  libpurple
  Version:  2.10.7       |   Keywords:  IM_DATA  IM_TEXT  ICBM__IM_SECTION
                         |  ICBM__IM_DATA_TAGS ICBM__CHANNEL_MSG_TOHOST
                         |  ICBM__CHANNEL_MSG_TOCLIENT
-------------------------+-------------------------------------------------
 Hi --

 The OSCAR protocol allows more than one IM_TEXT tag in an IM_DATA TLV but
 libpurple
 discards all but the last one in the ordered list (I guess there is also a
 memory leak).
 This means that an IM recipient may not see the complete text message that
 has been sent.

 The code in question is in incomingim_ch1_parsemsg
 (libpurple/protocols/oscar/family_icbm.c).  I have not checked whether
 this
 problem occurs anywhere else in libpurple/protocols/oscar.

 The attached file may not demonstrate an entirely correct solution, but it
 does produce the
 right result when pidgin receives an IM that contains two IM_TEXT tags.
 The current
 code will only display the content of the second (or last) IM_TEXT tag.

 Barry

-- 
Ticket URL: <https://developer.pidgin.im/ticket/15770>
Pidgin <http://pidgin.im>
Pidgin