[Pidgin] #15750: IRC ACTIONs skip sending-im-msg signal.

Pidgin trac at pidgin.im
Tue Apr 22 10:04:00 EDT 2014

#15750: IRC ACTIONs skip sending-im-msg signal.
 Reporter:  xnyhps                  |       Owner:  elb
     Type:  patch                   |      Status:  new
Milestone:  Patches Needing Review  |   Component:  IRC
  Version:  2.10.7                  |  Resolution:
 Keywords:  irc otr /me             |

Comment (by elb):

 That obfuscation is annoying and undesirable.  I have added a "security at
 pidgin.im" after the mailto URL.  I see the actual address when logged in,
 I'm not sure what's going on there.

 I'm probably the person to talk to, and I've provided some feedback on
 this on IRC and in the jabber conference.  I have not had time to do a
 proper review.  Here are my two cents on the ticket itself:

  * This patch causes plugin API issues, but I think the issues are
 probably trumped by the leak, and I doubt they'll cause a huge problem.
  * I don't particularly like that this drags conversation signal emissions
 into IRC.  There is almost certainly a better solution for this.
  * Neither of the above two issues would cause me to refuse this patch,
 because I think the former is a "bug" (given that other protocols pass a
 /me whatever through the signals API anyway) and the latter can always be
 mitigated later.

 If someone wants to apply this patch, I won't scream.  Tomasz?

Ticket URL: <https://developer.pidgin.im/ticket/15750#comment:32>
Pidgin <https://pidgin.im>

More information about the Tracker mailing list