[Pidgin] #16315: New API for private Raw and RTP data streams
Pidgin
trac at pidgin.im
Mon Dec 1 11:40:23 EST 2014
#16315: New API for private Raw and RTP data streams
------------------------------------+------------------------
Reporter: kakaroto | Owner:
Type: patch | Status: new
Milestone: Patches Needing Review | Component: libpurple
Version: 3.0.0hg | Resolution:
Keywords: |
------------------------------------+------------------------
Comment (by kakaroto):
Thanks for the review!
I didn't know about the main loop abstraction, thanks for pointing it out.
By the way, there were a couple of commits recently on the 'launchpad'
branch (instead of the 'appdata' branch) that fixes some deadlocks in the
appdata code. https://github.com/tieto/pidgin/commits/launchpad. I will
cherry pick them soon into the appdata branch as well.
As for the mainloop issue, the reason for that is we can get those signals
from the gstreamer streaming thread and we need to send the signals from
the libpurple thread. Should I just replace all of that with
purple_timeout_add(0, func, data) ? It should be simple enough, I'll let
you know when it's all done.
Thanks again for the review.
--
Ticket URL: <https://developer.pidgin.im/ticket/16315#comment:6>
Pidgin <https://pidgin.im>
Pidgin
More information about the Tracker
mailing list