[Pidgin] #15356: Remove MySpace IM PRPL

Pidgin trac at pidgin.im
Mon Feb 17 17:33:02 EST 2014

#15356: Remove MySpace IM PRPL
 Reporter:  pathorn  |       Owner:  MarkDoliner
     Type:  defect   |      Status:  closed
Milestone:  3.0.0    |   Component:  unclassified
  Version:  2.10.6   |  Resolution:  fixed
 Keywords:           |

Comment (by Robby):

 > Ah, sorry. You're right I should have thanked you in the commit message.
 To be clear, I was looking neither for attribution nor expression of
 gratitude. Any kind of acknowledgement is okay. Thanks for mentioning me
 in the changelog though.

 > For changes like this I feel like it's a little faster for me to just
 grep for "myspace" and make the changes myself rather than download a
 patch, apply it, make sure it didn't do anything bad, and still have to
 grep to make sure nothing was missed.
 This makes a lot of sense and is quite sufficient as an explanation (would
 have been in the first place). :-)

 > As for accepting the patch... I've never bothered to figure out how to
 set the author to someone else when committing things with Mercurial (also
 I'm kind of not a fan of it, because it's not clear as to who actually
 made the commit).[…]
 For what it's worth, `hg import` retains the author information of a
 patch. In Adium development, I've seen developers editing the commit
 message to add "r=<dev nick>" to indicate a patch has been reviewed. I
 also noticed Pidgin's web interface for the Mercurial repositories has a
 "pushlog" view which seems to display who pushed a commit.

Ticket URL: <https://developer.pidgin.im/ticket/15356#comment:15>
Pidgin <https://pidgin.im>

More information about the Tracker mailing list