[Pidgin] #4753: IRC messages silently truncated to first ~500 characters

Pidgin trac at pidgin.im
Thu Jul 10 13:16:00 EDT 2014


#4753: IRC messages silently truncated to first ~500 characters
-----------------------------+------------------
 Reporter:  tmetro           |       Owner:  elb
     Type:  defect           |      Status:  new
Milestone:  Patches welcome  |   Component:  IRC
  Version:  2.3.1            |  Resolution:
 Keywords:                   |
-----------------------------+------------------

Comment (by belmyst):

 http://forums.unrealircd.com/viewtopic.php?f=3&t=5999&p=29795&hilit=message+length#p29795

 A way to deal with this would be to check the ''packet'' length
 ({{{irc_send_len}}} on {{{irc.c}}}) prior to sending it (since otherwise
 you'd have to predict the final length on every part which constructs and
 send messages). If it's > 512 bytes, don't send it and error out.

 Another way could be by verifying the message's resulting length on
 {{{irc_format}}} ({{{parse.c}}}). The above check could be placed right
 prior to returning the message string.

 The attached fix uses the first approach, using cc86f44f12d0 as a
 guidance.

--
Ticket URL: <https://developer.pidgin.im/ticket/4753#comment:12>
Pidgin <https://pidgin.im>
Pidgin


More information about the Tracker mailing list