[Pidgin] #4753: IRC messages silently truncated to first ~500 characters

Pidgin trac at pidgin.im
Fri Jul 11 18:13:53 EDT 2014


#4753: IRC messages silently truncated to first ~500 characters
------------------------------------+------------------
 Reporter:  tmetro                  |       Owner:  elb
     Type:  defect                  |      Status:  new
Milestone:  Patches Needing Review  |   Component:  IRC
  Version:  2.3.1                   |  Resolution:
 Keywords:                          |
------------------------------------+------------------

Comment (by belmyst):

 Tyvm renatosilva.

 elb raised on IRC something similar. In my patch, the message size was
 checked without taking into account the server overhead:
 {{{":" + nick + "!" + user + "@" + host + " " + buf + " :" + CR LF}}}
 ({{{buf}}} being the {{{char *}}} being sent)
 However, since the server may set {{{nick}}}, {{{user}}} and {{{host}}} to
 something different to the values Pidgin has saved, we should take the
 worst case (everything max length) and reject anything that would overflow
 it.

 I've attached another version. Please review it.

--
Ticket URL: <https://developer.pidgin.im/ticket/4753#comment:15>
Pidgin <https://pidgin.im>
Pidgin


More information about the Tracker mailing list