[Pidgin] #16233: Custom emoticons don't show in XMPP under certain conditions

[Pidgin]

#16233: Custom emoticons don't show in XMPP under certain conditions
--------------------+-----------------------------------
 Reporter:  jvisc   |      Owner:
     Type:  defect  |     Status:  new
Milestone:          |  Component:  pidgin (gtk)
  Version:  2.10.9  |   Keywords:  emoticons,xmpp,pidgin
--------------------+-----------------------------------
 This occurs in XMPP group chat if a user with a different client joins
 (For example, Xabber).

 When this happens, the emoticon appears for the sender but no one else,
 not even other Pidgin clients who should normally be able to receive it.
 Thus, one bad user joining the chatroom blocks custom emoticons for
 everyone.

 An IQ BOB request is never received by the emoticon sender (normally I get
 one IQ request for each user).

 I have determined the cause to be something to do with the client not
 sending the following packets upon joining the room:

 {{{
 <c hash='sha-1' ver='I22W7CegORwdbnu0ZiQwGpxr0Go='
 node='http://pidgin.im/' xmlns='http://jabber.org/protocol/caps'/>

 <iq type='get' id='purple9e10147b' to='myroom at myserver.com'><query
 xmlns='http://jabber.org/protocol/disco#info'
 node='http://jabber.org/protocol/muc#traffic'/></iq>
 }}}

 I added this fix to my custom chatbot, and custom emoticons started
 working again. Both packets are required, and if any client doesn't send
 these packets, custom emoticons are blocked for everyone.


 Fixing this would be great because we use custom emoticons a lot, and it
 is a shame to have them blocked when an Android(Xabber) user joins.

-- 
Ticket URL: <https://developer.pidgin.im/ticket/16233>
Pidgin <https://pidgin.im>
Pidgin