[Pidgin] #16315: New API for private Raw and RTP data streams

[Pidgin]

#16315: New API for private Raw and RTP data streams
------------------------------------+------------------------
 Reporter:  kakaroto                |       Owner:
     Type:  patch                   |      Status:  new
Milestone:  Patches Needing Review  |   Component:  libpurple
  Version:  3.0.0hg                 |  Resolution:
 Keywords:                          |
------------------------------------+------------------------
Changes (by datallah):

 * cc: haakon, niklas.andersson@… (added)


Comment:

 Thanks for your efforts.  I got around to taking a brief look at this
 (even though I'm not very knowledgeable about the existing media stuff).

 I went ahead and committed 3 of the bugfixes - thanks for the granular
 commits, those make this process a lot easier.

 The development was done against the default branch, which will become the
 3.0.0 version of libpurple/pidgin.

 I was able to backport it to the release-2.x.y branch without any
 significant conflicts, and it does look like it is additive and from that
 perspective could go into a 2.11.0 release.

 I haven't fully finished reviewing the changes yet (and I haven't tried to
 build it yet), but I did notice an issue in that it depends on the glib
 main loop, which is problematic - pidgin uses the glib main loop, but
 libpurple itself has that abstracted out so that other applications can
 use their own native loop.
 See
 https://github.com/tieto/pidgin/commit/0d1866b868ee9882322644d1b6b088b2077fc2aa
 #diff-62d7c3b13ece872aa547d20dbd8e44c0R695 for example.

 I'll try to get the rest of the review done before too long - hopefully
 you can fix the main loop issue in the meantime.

--
Ticket URL: <https://developer.pidgin.im/ticket/16315#comment:5>
Pidgin <https://pidgin.im>
Pidgin