[Pidgin] #16391: URI escape breaks IPv6 links

[Pidgin]

#16391: URI escape breaks IPv6 links
---------------------+---------------------------------------
 Reporter:  cyisfor  |      Owner:  EionRobb
     Type:  patch    |     Status:  new
Milestone:  2.10.10  |  Component:  unclassified
  Version:  2.10.9   |   Keywords:  uri libpurple ipv6 escape
---------------------+---------------------------------------
 The recent method added to escape URIs before spawning them to try to
 avoid meta-characters like $() that some shells might interpret did not
 include [] in the list of allowed characters. As in IPv6 URLs the host
 address is surrounded in square brackets, those are escaped in the URL
 that is presented to the browser.

 Unfortunately the specification for http: URLs says that brackets in the
 host are allowed and not escaped, while they are escaped in the path. In
 any case, escaping them in the host field causes firefox to open a window,
 then just forget about the URL for some reason. (It should attempt to look
 up the name %5B123:4567:89a::::%5D and announce that hostname does not
 exist.)

 An easy fix is to just allow [] characters to be unescaped. If they're in
 the path they'll probably be escaped anyway, and I don't think they'll
 trigger any shell activity.

--
Ticket URL: <https://developer.pidgin.im/ticket/16391>
Pidgin <https://pidgin.im>
Pidgin