[Pidgin] #16616: [PATCH] Pidgin does not reconnect when NM report connectivity is back up

[Pidgin]

#16616: [PATCH] Pidgin does not reconnect when NM report connectivity is back up
---------------------+--------------------------
 Reporter:  ralfj    |      Owner:  EionRobb
     Type:  defect   |     Status:  new
Milestone:           |  Component:  unclassified
  Version:  2.10.11  |   Keywords:
---------------------+--------------------------
 Steps to reproduce:

 * Make sure some XMPP account is connected (may also work with other
 account types)
 * Be connected via LAN
 * Plug out the LAN cable
 * Wait until NM noticed
 * Plug it back in

 Expected behavior:
 Pidgin notices when the connection drops, and reconnects later.

 Actual behavior:
 Pidgin does not notice.

 More information:
 The reason is that the patch from
 <https://developer.pidgin.im/ticket/13505> does not suffice: The check in
 the "disconnected" state that makes sure the disconnect event is only
 dispatched to the UI when we were previously connected, has not been
 properly updated for the case that NM first downgrades from
 "CONNECTED_GLOBAL" to "CONNECTED_LOCAL", and only then to "DISCONNECTING".
 This is what NM does on my system when I unplug a LAN cable.
 The attached patch (against the release-2.x branch) fixes the check.

--
Ticket URL: <https://developer.pidgin.im/ticket/16616>
Pidgin <https://pidgin.im>
Pidgin