[Pidgin] #16617: [PATCH] Reconnecting when regaining connectivity sometimes fails

[Pidgin]

#16617: [PATCH] Reconnecting when regaining connectivity sometimes fails
---------------------+--------------------------
 Reporter:  ralfj    |      Owner:  EionRobb
     Type:  defect   |     Status:  new
Milestone:           |  Component:  unclassified
  Version:  2.10.11  |   Keywords:
---------------------+--------------------------
 Steps to reproduce:
 * Be connected to some XMPP account (other account types should have the
 same problem)
 * Click "Disconnect" on the active connection in NM
 * Connect back

 Expected behavior:
 Pidgin should reliably reconnect to the server.

 Actual behavior:
 Pidgin sometimes fails to do so.

 More information:
 NM first sends "CONNECTED_LOCAL", and only slightly later it sends
 "CONNECTED_GLOBAL". Pidgin starts connecting on the first signal already.
 In case Pidgin is too fast, this attempt fails.
 I *think* Pidgin should not treat CONENCTED_LOCAL as a signal to connect
 to anything. For CONNECTED_SITE, one could make the argument that there
 could be site-local servers that are now available. But for
 CONNECTED_LOCAL, I cannot come up with a usecase. Hence attached patch
 treats CONNECTED_LOCAL like DISCONNECTED - for most servers, it really is.

 The patch is *on top* of the one for
 <https://developer.pidgin.im/ticket/16616>.

--
Ticket URL: <https://developer.pidgin.im/ticket/16617>
Pidgin <https://pidgin.im>
Pidgin