[Pidgin] #16535: less delay for xmpp file transfer using streamhosts

[Pidgin]

#16535: less delay for xmpp file transfer using streamhosts
------------------------------------------+------------------------
 Reporter:  evert_mouw                    |       Owner:
     Type:  patch                         |      Status:  new
Milestone:  Patches Needing Review        |   Component:  libpurple
  Version:  2.10.11                       |  Resolution:
 Keywords:  XMPP streamhost filetransfer  |
------------------------------------------+------------------------

Comment (by evert_mouw):

 Hi datallah,

 The ordering as it is currently done is, as far as I understand,
 completely random, so any ordering that has a few assumptions right is an
 improvement.

 My first assumption is that direct connections between XMPP clients very
 often fail due to NAT and firewalls. If there is a proper proxy proposed
 by the client (it does not propose a proxy without reason! the user did
 put the proxy in the configuration with the intention to actually use that
 proxy), then use that! My code just tries to order the streamhosts offered
 by the peer (client).

 My assumption is that hosts with DNS hostnames have a higher chance of
 being a properly configured proxy. If they are on port 7777, then it is
 almost sure that it is a well-configured proxy.

 If the patch would be accepted without the ordering, but with 0.0.0.0
 filtering and shorter timeout accepted, it would already be an
 improvement. But please give the ordering some thought. Especially the "if
 port 7777, assume higher probability of being the best shot" is useful,
 IMHO.

--
Ticket URL: <https://developer.pidgin.im/ticket/16535#comment:3>
Pidgin <https://pidgin.im>
Pidgin