[Pidgin] #16001: Duplicate calls to purple_xfer_set_bytes_sent()

Pidgin trac at pidgin.im
Tue Jun 23 11:50:47 EDT 2015

#16001: Duplicate calls to purple_xfer_set_bytes_sent()
 Reporter:  MarkDoliner  |       Owner:  tomkiewicz
     Type:  defect       |      Status:  new
Milestone:  3.0.0        |   Component:  libpurple
  Version:  3.0.0hg      |  Resolution:
 Keywords:               |

Comment (by mmcco):

 Replying to [comment:5 tomkiewicz]:
 > Replying to [comment:3 mmcco]:
 > > It seems that `do_transfer()`, regardless of what it was intended to
 be, is in practice an abstraction used internally by libpurple's rather
 than part of the API. No protocol uses it directly. Jabber and MSN use it
 through `purple_xfer_protocol_ready()`.
 > It is a static function, so it can't be even theoretically used outside
 of that module.

 Oh, good call, I totally missed that.  :)  I was hoping to find a quick
 fix, but it's been surprisingly difficult to diagnose this slight
 truncation issue.

 Anecdotally, I've removed the `bytes_remaining` attribute of
 `PupleXferPrivate`, which is simply `size - bytes_sent` and is already
 accessed through a helper function regardless. As you mentioned, there are
 definitely some simplifications to be made in our file transfer code.

Ticket URL: <https://developer.pidgin.im/ticket/16001#comment:6>
Pidgin <https://pidgin.im>

More information about the Tracker mailing list