[Pidgin] #16697: Replacing GTK Stock Items

[Pidgin]

#16697: Replacing GTK Stock Items
---------------------+---------------------------
 Reporter:  mmcco    |       Owner:
     Type:  defect   |      Status:  new
Milestone:  3.0.0    |   Component:  pidgin (gtk)
  Version:  3.0.0hg  |  Resolution:
 Keywords:           |
---------------------+---------------------------

Comment (by mmcco):

 I think I've taken care of most of this, with a few goofs along the way.

 Here are the relevant commits:

 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/9b3a8112fa25
 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/adf32a9a987d
 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/5d4a86d3ccca
 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/a06fddb594ed
 * https://hg.pidgin.im/soc/2015/mmcc/main/rev/9fa564642a58

 There are a few stock items left in the Pidgin^^Stock API that didn't have
 direct corollaries in the migration guide. Namely:

 * `GTK_STOCK_EDIT`
 * `GTK_STOCK_CANCEL`
 * `GTK_STOCK_APPLY`
 * `GTK_STOCK_DISCONNECT`

 See here:

 https://hg.pidgin.im/soc/2015/mmcc/main/rev/a06fddb594ed#l22.1

 ''(Ignore the `N_("_Executive")` line - that was a mistake fixed in the
 next commit.)''

 The GTK people suggest using `gtk3-icon-browser` to choose icons. Who
 thinks they can do a good job of that?

 Note also that this will break third-party plugin code previously written
 for the Pidgin^^Stock API.

--
Ticket URL: <https://developer.pidgin.im/ticket/16697#comment:3>
Pidgin <https://pidgin.im>
Pidgin