[Pidgin] #12617: Patch to add out-of-band DTMF support

Pidgin trac at pidgin.im
Fri Mar 6 16:00:26 EST 2015

#12617: Patch to add out-of-band DTMF support
 Reporter:  BigBrownChunx           |       Owner:  darkrain42
     Type:  patch                   |      Status:  new
Milestone:  Patches Needing Review  |   Component:  libpurple
  Version:  2.7.3                   |  Resolution:
 Keywords:  dtmf media              |

Comment (by elb):

 Comments on attachment:pidgin2-dtmf.patch:

 I would like to see purple_media_send_dtmf() changed to take at least a
 16-bit duration allowing a duration of up to 1 second.  256 ms is fairly
 short for some (particularly radio) applications.  I would also like to
 see it ensure that the incoming characters are in [0-9A-D#*], since it
 specifies such in its documentation (as it should).

 The invocation of dgettext in pidgin should be _(), I think.  We don't
 call dgettext explicitly in Pidgin.

 This patch otherwise looks suitable for inclusion to me.

Ticket URL: <https://developer.pidgin.im/ticket/12617#comment:20>
Pidgin <https://pidgin.im>

More information about the Tracker mailing list