[Pidgin] #16658: Mac OS X Menubar

[Pidgin]

#16658: Mac OS X Menubar
-------------------------------------------------+-------------------------
 Reporter:  pmsaraiva                            |       Owner:
     Type:  enhancement                          |      Status:  new
Milestone:                                       |   Component:  pidgin
                                                 |  (gtk)
  Version:  2.10.11                              |  Resolution:
 Keywords:  mac os x integration menubar menu    |
  bar                                            |
-------------------------------------------------+-------------------------

Comment (by QuLogic):

 I can't say much about the effectiveness of the patch, but as to its
 content: you seem to have added a lot of extra lines consisting solely of
 whitespace. Please remove these from your patch.

 You also use variable declarations wherever you like, but as we are using
 C89, that is not allowed. Please keep all variable declarations at the
 beginning of a block.

 There is also one point where you have:

 {{{
 #ifndef MAC_INTEGRATION
     GtkosxApplication *app = ...
 }}}

 The macro logic seems backwards here.

--
Ticket URL: <https://developer.pidgin.im/ticket/16658#comment:1>
Pidgin <https://pidgin.im>
Pidgin