[Pidgin] #16762: Don't remove transient startup status from saved_statuses

[Pidgin]

#16762: Don't remove transient startup status from saved_statuses
---------------------+----------------------------
 Reporter:  haakon   |      Owner:
     Type:  patch    |     Status:  new
Milestone:           |  Component:  libpurple
  Version:  3.0.0hg  |   Keywords:  startup status
---------------------+----------------------------
 It was possible for a transient saved status that was also set as the
 startup status to get removed on shutdown, when libpurple calls
 remove_old_transient_statuses(). Consequently, when the client was started
 next time, its status got incorrectly set to the last 'current' status
 instead.

 We should always keep startup status in the list of saved statuses, same
 as we do with current status.

 This could happen with Pidgin when user selected some of the pre-filled
 primitive statuses from the combo box at Preferences > Status / Idle
 (Pidgin may create a new transient status for such selected item in
 gtksavedstatuses.c:status_menu_cb()).

 This patch should be applicable to both 'release-2.x.y' and 'default'
 branches.

 Though the description is pretty vague, it appears that it also fixes
 defect #14758.

--
Ticket URL: <https://developer.pidgin.im/ticket/16762>
Pidgin <https://pidgin.im>
Pidgin