[Pidgin] #16764: Pidgin/finch fails to build against ncurses 6.0 with WINDOW_OPAQUE set to 1

[Pidgin]

#16764: Pidgin/finch fails to build against ncurses 6.0 with WINDOW_OPAQUE set to 1
------------------------------------+---------------------------
 Reporter:  dimstar                 |       Owner:  EionRobb
     Type:  patch                   |      Status:  new
Milestone:  Patches Needing Review  |   Component:  unclassified
  Version:  2.10.11                 |  Resolution:
 Keywords:                          |
------------------------------------+---------------------------
Changes (by Robby):

 * type:  defect => patch
 * milestone:   => Patches Needing Review


Old description:

> openSUSE is in progress of updating ncurses to version 6.0 and
> WINDOW_OPAQUE is being set to 1.
>
> This results in build failures of finch, with this kind of log:
>

> {{{
> [  868s]   CC       gntws.lo
> [  868s] gntwm.c: In function 'work_around_for_ncurses_bug':
> [  868s] gntwm.c:177:18: error: dereferencing pointer to incomplete type
> 'WINDOW {aka struct _win_st}'
> [  868s]    sx = panel->win->_begx;
> [  868s]                   ^
> [  868s] Makefile:738: recipe for target 'gntwm.lo' failed
> }}}
>

> The issue being, that when WINDOW_OPAQUE is enabled in ncurses, the
> WINDOW struct is not supposed to be accessed directly, but only thruogh
> accessor functions

New description:

 openSUSE is in progress of updating ncurses to version 6.0 and
 WINDOW_OPAQUE is being set to 1.

 This results in build failures of finch, with this kind of log:

 {{{
 [  868s]   CC       gntws.lo
 [  868s] gntwm.c: In function 'work_around_for_ncurses_bug':
 [  868s] gntwm.c:177:18: error: dereferencing pointer to incomplete type
 'WINDOW {aka struct _win_st}'
 [  868s]    sx = panel->win->_begx;
 [  868s]                   ^
 [  868s] Makefile:738: recipe for target 'gntwm.lo' failed
 }}}

 The issue being, that when WINDOW_OPAQUE is enabled in ncurses, the WINDOW
 struct is not supposed to be accessed directly, but only thruogh accessor
 functions

--

--
Ticket URL: <https://developer.pidgin.im/ticket/16764#comment:6>
Pidgin <https://pidgin.im>
Pidgin